Skip to content

[No QA] Update XERO45 help article - #102185

Merged
yuwenmemon merged 5 commits into
Expensify:mainfrom
jjcoffee:xero45-help-article
Sep 24, 2026
Merged

yuwenmemon merged 5 commits into
Expensify:mainfrom
jjcoffee:xero45-help-article

Conversation

@jjcoffee

@jjcoffee jjcoffee commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The XERO45 article told people to disconnect Xero and then reconnect. Disconnecting wipes your imported data and all your Xero settings, so anyone following the article lost their setup and had to build it again.

In reality, you don't actually need to disconnect to fix the error, so both articles have been updated to say that.

A few other things needed updating to match:

  • The error message itself changed in the backend PR.
  • The old article said one cause was the Xero token expiring, which is no longer correct as we now renew tokens in the background. If we can't reach Xero temporarily, that now shows as XERO46 instead.
  • The intro and FAQ for ND explain that the Xero settings are hidden while this error is showing, and that they come back once you reconnect.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/679831
PROPOSAL: N/A

Tests

  1. Open the ExpensifyHelp preview link from the comment on this PR.
  2. Go to /articles/expensify-classic/connections/xero/Troubleshooting/Sync-Errors/XERO45-Sync-Error.
  3. Check the article renders with one title, the sections below it, and the FAQ at the bottom.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@jjcoffee
jjcoffee marked this pull request as ready for review September 24, 2026 13:48
@jjcoffee jjcoffee changed the title Update XERO45 help article [No QA] Update XERO45 help article Sep 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates the XERO45 sync error articles for both Expensify Classic and New Expensify. The core content change is excellent: it corrects a genuinely harmful instruction (disconnect + reconnect, which wipes imported data and settings) and replaces it with a safe reconnect-only flow. The new error message, the XERO46 distinction, and the ND note about hidden settings are all accurate and well explained. The prose is clear and the FAQ was meaningfully expanded. The main gaps are structural/style: heading hierarchy violations and the three dots menu convention.

Scores Summary

  • Readability: 9/10 - Clear, plain-language sentences, well-sequenced numbered steps, and a strong, expanded FAQ. Easy to scan and act on.
  • AI Readiness: 7/10 - Strong internalScope/keywords/description metadata and good search-aligned FAQ questions, but heading hierarchy is broken in both files, which hurts structured retrieval.
  • Style Compliance: 6/10 - UI labels are mostly exact and bolded correctly, but the three dots menu convention is not followed, and some section headings are Title Case rather than sentence case.

Key Findings

  • Positive: The content fix is high value and accurate. Removing the destructive disconnect step, clarifying that reconnecting preserves data/config, and distinguishing XERO45 from XERO46 are exactly right.
  • Positive: Cross-links use descriptive anchor text ("learn how to connect to Xero"), relative links, and sit outside numbered steps, per Cross-Linking Standards.
  • Positive: FAQ additions map to real user questions ("Do I Need to Disconnect Xero Before Reconnecting?", "Does the XERO45 Error Mean Data Was Lost in Xero?").
  • Heading hierarchy (Classic): under the "How to Fix the XERO45 Sync Error" H2, the proposed content keeps H3 subsections ("Reconnect to Xero", "Retry the Sync"). H3 is not allowed - only H1 and H2 (HELP_AUTHORING_GUIDELINES Section 4 and validation checklist).
  • Heading hierarchy (New Expensify): "How to Fix the XERO45 Sync Error" is a second non-FAQ H1 heading. Only one H1 (the title) plus the FAQ H1 is allowed; demote this to H2.
  • Three dots menu (both files): lines such as "Click the three-dot icon next to the Xero connection" must follow the exact convention required by HELPSITE_NAMING_CONVENTIONS (Three Dots Menu Rule): always write "the three dots" plus the bolded vertical-dots symbol in parentheses.
  • Casing: several H2 headings use Title Case (e.g., "Do I Need Xero Admin Access to Reconnect?", "Reconnect to Xero in the Workspace"). Naming conventions favor sentence case matching product style; recommend sentence case for consistency.
  • Minor: The Sync button is referenced inconsistently - Classic uses "Sync Now", ND uses "Sync now". Use the exact UI casing consistently.

Recommendations

  • Priority 1: Fix heading levels. Classic: convert the H3 subsections to H2. ND: demote the "How to Fix the XERO45 Sync Error" H1 to H2. This resolves the AI Readiness deductions.
  • Priority 2: Replace all "three-dot icon" references with the exact three dots convention per HELPSITE_NAMING_CONVENTIONS.
  • Priority 3: Normalize H2 section and FAQ headings to sentence case, and standardize the Sync button label casing to match the UI exactly.

Files Reviewed

  • docs/articles/expensify-classic/connections/xero/Troubleshooting/Sync-Errors/XERO45-Sync-Error.md - Content excellent; fix H3 headings and three dots reference.
  • docs/articles/new-expensify/connections/xero/Troubleshooting/Sync-Errors/XERO45-Sync-Error.md - Content excellent; demote the second H1 heading and fix three dots reference.

Note: Detailed line-by-line feedback has been provided as inline comments.

@jjcoffee
jjcoffee requested a review from yuwenmemon September 24, 2026 14:25
@yuwenmemon
yuwenmemon merged commit e436372 into Expensify:main Sep 24, 2026
15 of 16 checks passed
@jjcoffee
jjcoffee deleted the xero45-help-article branch September 25, 2026 07:45
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants